Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving structs PointLight, SpotLight, and DirectionalLight out of light/mod.rs #12656

Merged
merged 11 commits into from
Mar 23, 2024
Merged

Moving structs PointLight, SpotLight, and DirectionalLight out of light/mod.rs #12656

merged 11 commits into from
Mar 23, 2024

Conversation

nbielans
Copy link
Contributor

Objective

Follow up from PR #12369 to extract lighting structs from light/mod.rs into their own file.
Part of the Purdue Refactoring Team's goals issue #12349

Solution

  • Moved PointLight from light/mod.rs to light/point_light.rs
  • Moved SpotLight from light/mod.rs to light/spot_light.rs
  • Moved DirectionalLight from light/mod.rs to light/directional_light.rs

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Mar 22, 2024
@james7132 james7132 added this pull request to the merge queue Mar 23, 2024
Merged via the queue into bevyengine:main with commit d836ece Mar 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbielans @james7132 @alice-i-cecile