Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entity id to hierarchy propagation error message #12733

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Add entity id to hierarchy propagation error message #12733

merged 2 commits into from
Mar 26, 2024

Conversation

cBournhonesque
Copy link
Contributor

Objective

Solution

  • Use the Name component if present, else default to Entity 0v1 instead of An entity

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Hierarchy Parent-child entity hierarchies labels Mar 26, 2024
@alice-i-cecile
Copy link
Member

@spectria-limina review here please :)

@bugsweeper
Copy link
Contributor

I think Option::map_or_else is better here, because Option::map_or would format! string even in case of Option containing Some(value)

@cBournhonesque
Copy link
Contributor Author

I think Option::map_or_else is better here, because Option::map_or would format! string even in case of Option containing Some(value)

great point

@spectria-limina
Copy link
Contributor

LGTM

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 26, 2024
Merged via the queue into bevyengine:main with commit b7ab146 Mar 26, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Hierarchy Parent-child entity hierarchies C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing GlobalTransform warnings don't help you identify the offending entity
4 participants
@cBournhonesque @alice-i-cecile @bugsweeper @spectria-limina