remove close_on_esc

[matiqo15]

Objective

• Remove close_on_esc
• For context about why we are removing it see: discord

Migration Guide

• Users who added close_on_esc in their application will have to replace it with their own solution.

pub fn close_on_esc(
    mut commands: Commands,
    focused_windows: Query<(Entity, &Window)>,
    input: Res<ButtonInput<KeyCode>>,
) {
    for (window, focus) in focused_windows.iter() {
        if !focus.focused {
            continue;
        }

        if input.just_pressed(KeyCode::Escape) {
            commands.entity(window).despawn();
        }
    }
}

[pablo-lua]

We can think if we will have this kind of helper systems in the future, but should probably be much more configurable and inside some toolbox or plugin. Lets remove this!

[mockersf]

@DJMcNab I think you want to keep it?

[DJMcNab]

I mean, I'm not using Bevy regularly at the moment, so I'm not really that bothered either way.

I do find the equivalent functionality in Vello's example to be very useful though.

[djeedai]

Please don't link Discord in PR descriptions unless absolutely necessary. I spent 10 min trying to find an explanation, I can't. The only thing I find on Discord is people complaining that it was removed too quickly and/or arguing it should have been kept and is very useful, which doesn't really help support the cause for this PR. @matiqo15 @alice-i-cecile @mockersf