Ellipse functions #13025
Merged
Ellipse functions #13025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthTensor
added
C-Feature
mweatherley
suggested changes
Apr 19, 2024
There was a problem hiding this comment.
This mostly looks good (I'd just like a little more in the way of sources); it would be nice to have some additional motivation beyond just "filling in the gaps" though (especially for something like focal length, where I don't really know what it's used for).
mweatherley
approved these changes
Apr 21, 2024
IQuick143
reviewed
Apr 23, 2024
| (a * a - b * b).sqrt() | ||
| } | ||
|
|
||
| #[inline(always)] |
There was a problem hiding this comment.
Do we want to always inline this function, considering it's a pretty long method?
There was a problem hiding this comment.
Most of it is just the const array and excluding that, the method really isn't that long. In the end, this is probably a design decision, so if you believe it should be removed, I am happy to do so
Co-Authored-By: IQuick 143 <IQuick143cz@gmail.com>
pablo-lua
approved these changes
May 6, 2024
pablo-lua
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
EllipseSolution
Ellipse::perimeter()and::focal_length()