-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix motion blur on wasm #13099
Fix motion blur on wasm #13099
Conversation
It seems that there are other issues when building with webgpu that need to be addressed:
edit: binding 5 is |
Tested I had to modify the cfg gating for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just standard annoying webgl2 padding. I tested on Linux and wasm webgl2 and both works.
Bummer, this was working at one point, but I forgot to re-test closer to final merge. Thanks! |
Objective
Fixes #13097 and other issues preventing the motion blur example from working on wasm
Solution
MotionBlur
struct on wasm+webgl2GlobalsUniform
padding getting added on the shader side for webgpu buildsNotes
The motion blur example now runs, but with artifacts. In addition to the obvious black artifacts, the motion blur or dithering seem to just look worse in a way I can't really describe. That may be expected.