Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix emissive value in StandardMaterial after swith to LinearRgba #13502

Merged
merged 1 commit into from
May 25, 2024
Merged

fix emissive value in StandardMaterial after swith to LinearRgba #13502

merged 1 commit into from
May 25, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Use the correct value for emissive in StandardMaterial. It's computed just above but unused

    bevy/crates/bevy_pbr/src/pbr_material.rs

    Lines 975 to 976 in d875058

    let mut emissive = self.emissive.to_vec4();
    emissive[3] = self.emissive_exposure_weight;

Testing

  • Run example bloom_3d

@mockersf mockersf added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! A-Color Color spaces and color math labels May 25, 2024
@mockersf mockersf added this to the 0.14 milestone May 25, 2024
@mockersf mockersf mentioned this pull request May 25, 2024
Merged
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 25, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 25, 2024
Merged via the queue into bevyengine:main with commit 0ec6347 May 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Color Color spaces and color math A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @alice-i-cecile