Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up substate code a bit #13638

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Clean up substate code a bit #13638

merged 1 commit into from
Jun 3, 2024

Conversation

benfrankel
Copy link
Contributor

@benfrankel benfrankel commented Jun 2, 2024 •
edited
Loading

Objective

Small substate code cleanup.

  1. Format closure arguments inside macros.
  2. Replace match bool blocks with if-else blocks.
  3. Replace match block in substate macro with the same one-liner as in the non-macro version.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Jun 3, 2024
alice-i-cecile
alice-i-cecile approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My beloved match on bool :( Unfortunately it's not the code style we use here.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Macros Code that generates Rust code labels Jun 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bevyengine:main with commit 52ace67 Jun 3, 2024
31 checks passed
@benfrankel benfrankel deleted the small-cleanup branch July 17, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiniaczQ MiniaczQ MiniaczQ approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Macros Code that generates Rust code S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benfrankel @alice-i-cecile @MiniaczQ