Use raw-window-handle to tie wgpu with winit #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
added
C-Feature
…ible for other backends like SDL2 to be integrated.
aclysma
force-pushed
the
use-raw-window-handle
branch
from
019769b
to
eeb795c
Compare
|
Rebased to head |
Closed
alice-i-cecile
added
the
S-Ready-For-Final-Review
DJMcNab
removed
the
S-Ready-For-Final-Review
cart
added
the
S-Pre-Relicense
mockersf
removed
the
S-Pre-Relicense
|
Closing, I heard the renderer rework is using raw window handle directly. In any case, enough time has passed that anyone wanting to implement this probably should start from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for other backends like SDL2 to be integrated. https://github.com/aclysma/prototype_bevy_sdl2 demonstrates this being used.
There is some unsafety in wrapping RawWIndowHandle in BevyRawWindowHandle to force it to be Send/Sync. The resources within the RawWindowHandle are raw FFI pointers. On one hand, since they're just pointers there's a good chance they are safe as long as they aren't in practice used from multiple threads - and it does work on macOS. On the other hand, I have not reviewed the API docs in detail for every platform RawWindowHandle is compatible with and those platforms might prohibit using those resources in certain ways from a different thread.
I'm creating this as a draft so that we can discuss if this is a possible approach, or if someone can come up with an alternative. For example, perhaps a handler could be made available to the windowing code so that the wire-up with the rendering API to create the surface can happen immediately in the windowing code.