Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fixed Android example icon #4076

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fixed Android example icon #4076

wants to merge 1 commit into from

Conversation

ManevilleF
Copy link
Contributor

Objective

  • The android example icon doesn't show up

Solution

  • I fixed the android metadata to match cargo-apk manifest

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 1, 2022
@ManevilleF
Copy link
Contributor Author

Note that the example still crashes, this only fixes the icon

@mockersf mockersf added O-Android Specific to the Android mobile operating system and removed S-Needs-Triage This issue needs to be labelled labels Mar 1, 2022
@alice-i-cecile alice-i-cecile added the C-Examples An addition or correction to our examples label Mar 4, 2022
@ManevilleF ManevilleF mentioned this pull request Mar 7, 2022
Closed
@ManevilleF
Copy link
Contributor Author

@alice-i-cecile Going through my open PRs I think this can be merged

@alice-i-cecile
Copy link
Member

I fixed the android metadata to match cargo-apk manifest

Can you link this to me? Having a bit of trouble finding it. Once that's done I'm happy to merge this as trivial.

@ManevilleF
Copy link
Contributor Author

https://github.com/rust-windowing/android-ndk-rs/tree/master/cargo-apk#manifest

mockersf
mockersf reviewed Jun 24, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@ManevilleF ManevilleF force-pushed the feat/fix_android_example_icon branch from ea30353 to a69fafe Compare June 24, 2022 20:24
@ManevilleF
Copy link
Contributor Author

Rebased on main and applied review comments

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 24, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 24, 2022
@ManevilleF
Fixed Android example icon (#4076)
ad88bda 
# Objective

- The android example icon doesn't show up

## Solution

- I fixed the android metadata to match `cargo-apk` manifest
@bors
Copy link
Contributor

bors bot commented Jun 24, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fixed Android example icon [Merged by Bors] - Fixed Android example icon Jun 24, 2022
@bors bors bot closed this Jun 24, 2022
@ManevilleF ManevilleF deleted the feat/fix_android_example_icon branch June 25, 2022 08:34
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@ManevilleF @inodentry
Fixed Android example icon (bevyengine#4076)
ea63ff9 
# Objective

- The android example icon doesn't show up

## Solution

- I fixed the android metadata to match `cargo-apk` manifest
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@ManevilleF @james7132
Fixed Android example icon (bevyengine#4076)
01bd2c2 
# Objective

- The android example icon doesn't show up

## Solution

- I fixed the android metadata to match `cargo-apk` manifest
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ManevilleF @ItsDoot
Fixed Android example icon (bevyengine#4076)
3857d8a 
# Objective

- The android example icon doesn't show up

## Solution

- I fixed the android metadata to match `cargo-apk` manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples O-Android Specific to the Android mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManevilleF @alice-i-cecile @mockersf