[Merged by Bors] - bevy_reflect: Add `GetTypeRegistration` impl for reflected tuples #4226

MrGVSV · 2022-03-16T05:27:31Z

Objective

Reflected tuples do not implement GetTypeRegistration, preventing us from registering our tuples, like:

app.register_type::<(i32, i32)>();

This is especially important for things like using #4042 to improve the scene format or implementing #4154 to recursively register fields.

Solution

Added an implementation to the tuple macro:

impl<$($name: Reflect + for<'de> Deserialize<'de>),*> GetTypeRegistration for ($($name,)*) {
  fn get_type_registration() -> TypeRegistration {
    let mut registration = TypeRegistration::of::<($($name,)*)>();
    registration.insert::<ReflectDeserialize>(FromType::<($($name,)*)>::from_type());
    registration
  }
}

This requires that the tuple's types implement Deserialize. This is exactly how Vec and HashMap handle it:

impl<T: FromReflect + for<'de> Deserialize<'de>> GetTypeRegistration for Vec<T> {
  fn get_type_registration() -> TypeRegistration {
    let mut registration = TypeRegistration::of::<Vec<T>>();
    registration.insert::<ReflectDeserialize>(FromType::<Vec<T>>::from_type());
    registration
  }
}

alice-i-cecile · 2022-03-16T05:51:04Z

Makes sense, and code looks good to me :)

alice-i-cecile · 2022-05-02T12:10:28Z

bors r+

) # Objective Reflected tuples do not implement `GetTypeRegistration`, preventing us from registering our tuples, like: ```rust app.register_type::<(i32, i32)>(); ``` This is especially important for things like using #4042 to improve the scene format or implementing #4154 to recursively register fields. ## Solution Added an implementation to the tuple macro: ```rust impl<$($name: Reflect + for<'de> Deserialize<'de>),*> GetTypeRegistration for ($($name,)*) { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<($($name,)*)>(); registration.insert::<ReflectDeserialize>(FromType::<($($name,)*)>::from_type()); registration } } ``` This requires that the tuple's types implement `Deserialize`. This is exactly how `Vec` and `HashMap` handle it: ```rust impl<T: FromReflect + for<'de> Deserialize<'de>> GetTypeRegistration for Vec<T> { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<Vec<T>>(); registration.insert::<ReflectDeserialize>(FromType::<Vec<T>>::from_type()); registration } } ```

bors · 2022-05-02T12:21:53Z

This PR was included in a batch that was canceled, it will be automatically retried

) # Objective Reflected tuples do not implement `GetTypeRegistration`, preventing us from registering our tuples, like: ```rust app.register_type::<(i32, i32)>(); ``` This is especially important for things like using #4042 to improve the scene format or implementing #4154 to recursively register fields. ## Solution Added an implementation to the tuple macro: ```rust impl<$($name: Reflect + for<'de> Deserialize<'de>),*> GetTypeRegistration for ($($name,)*) { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<($($name,)*)>(); registration.insert::<ReflectDeserialize>(FromType::<($($name,)*)>::from_type()); registration } } ``` This requires that the tuple's types implement `Deserialize`. This is exactly how `Vec` and `HashMap` handle it: ```rust impl<T: FromReflect + for<'de> Deserialize<'de>> GetTypeRegistration for Vec<T> { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<Vec<T>>(); registration.insert::<ReflectDeserialize>(FromType::<Vec<T>>::from_type()); registration } } ```

bors · 2022-05-02T12:41:29Z

Build failed (retrying...):

build (stable, macos-latest)

) # Objective Reflected tuples do not implement `GetTypeRegistration`, preventing us from registering our tuples, like: ```rust app.register_type::<(i32, i32)>(); ``` This is especially important for things like using #4042 to improve the scene format or implementing #4154 to recursively register fields. ## Solution Added an implementation to the tuple macro: ```rust impl<$($name: Reflect + for<'de> Deserialize<'de>),*> GetTypeRegistration for ($($name,)*) { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<($($name,)*)>(); registration.insert::<ReflectDeserialize>(FromType::<($($name,)*)>::from_type()); registration } } ``` This requires that the tuple's types implement `Deserialize`. This is exactly how `Vec` and `HashMap` handle it: ```rust impl<T: FromReflect + for<'de> Deserialize<'de>> GetTypeRegistration for Vec<T> { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<Vec<T>>(); registration.insert::<ReflectDeserialize>(FromType::<Vec<T>>::from_type()); registration } } ```

bors · 2022-05-02T14:55:23Z

Canceled.

alice-i-cecile · 2022-05-02T14:58:28Z

bors r+

) # Objective Reflected tuples do not implement `GetTypeRegistration`, preventing us from registering our tuples, like: ```rust app.register_type::<(i32, i32)>(); ``` This is especially important for things like using #4042 to improve the scene format or implementing #4154 to recursively register fields. ## Solution Added an implementation to the tuple macro: ```rust impl<$($name: Reflect + for<'de> Deserialize<'de>),*> GetTypeRegistration for ($($name,)*) { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<($($name,)*)>(); registration.insert::<ReflectDeserialize>(FromType::<($($name,)*)>::from_type()); registration } } ``` This requires that the tuple's types implement `Deserialize`. This is exactly how `Vec` and `HashMap` handle it: ```rust impl<T: FromReflect + for<'de> Deserialize<'de>> GetTypeRegistration for Vec<T> { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<Vec<T>>(); registration.insert::<ReflectDeserialize>(FromType::<Vec<T>>::from_type()); registration } } ```

bors · 2022-05-02T16:04:43Z

This PR was included in a batch that timed out, it will be automatically retried

) # Objective Reflected tuples do not implement `GetTypeRegistration`, preventing us from registering our tuples, like: ```rust app.register_type::<(i32, i32)>(); ``` This is especially important for things like using #4042 to improve the scene format or implementing #4154 to recursively register fields. ## Solution Added an implementation to the tuple macro: ```rust impl<$($name: Reflect + for<'de> Deserialize<'de>),*> GetTypeRegistration for ($($name,)*) { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<($($name,)*)>(); registration.insert::<ReflectDeserialize>(FromType::<($($name,)*)>::from_type()); registration } } ``` This requires that the tuple's types implement `Deserialize`. This is exactly how `Vec` and `HashMap` handle it: ```rust impl<T: FromReflect + for<'de> Deserialize<'de>> GetTypeRegistration for Vec<T> { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<Vec<T>>(); registration.insert::<ReflectDeserialize>(FromType::<Vec<T>>::from_type()); registration } } ```

bors · 2022-05-02T18:26:39Z

Pull request successfully merged into main.

Build succeeded:

…vyengine#4226) # Objective Reflected tuples do not implement `GetTypeRegistration`, preventing us from registering our tuples, like: ```rust app.register_type::<(i32, i32)>(); ``` This is especially important for things like using bevyengine#4042 to improve the scene format or implementing bevyengine#4154 to recursively register fields. ## Solution Added an implementation to the tuple macro: ```rust impl<$($name: Reflect + for<'de> Deserialize<'de>),*> GetTypeRegistration for ($($name,)*) { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<($($name,)*)>(); registration.insert::<ReflectDeserialize>(FromType::<($($name,)*)>::from_type()); registration } } ``` This requires that the tuple's types implement `Deserialize`. This is exactly how `Vec` and `HashMap` handle it: ```rust impl<T: FromReflect + for<'de> Deserialize<'de>> GetTypeRegistration for Vec<T> { fn get_type_registration() -> TypeRegistration { let mut registration = TypeRegistration::of::<Vec<T>>(); registration.insert::<ReflectDeserialize>(FromType::<Vec<T>>::from_type()); registration } } ```

github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 16, 2022

alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types and removed S-Needs-Triage This issue needs to be labelled labels Mar 16, 2022

alice-i-cecile approved these changes Mar 16, 2022

View reviewed changes

james7132 approved these changes Mar 21, 2022

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 21, 2022

MrGVSV changed the title ~~Add GetTypeRegistration impl for reflected tuples~~ bevy_reflect: Add GetTypeRegistration impl for reflected tuples Mar 28, 2022

alice-i-cecile added this to the Bevy 0.8 milestone Apr 25, 2022

Added GetTypeRegistration impl for reflected tuples

99ceab0

MrGVSV force-pushed the reflect-tuple-registration branch from 4e1a9ee to 99ceab0 Compare May 2, 2022 14:55

bors bot changed the title ~~bevy_reflect: Add GetTypeRegistration impl for reflected tuples~~ [Merged by Bors] - bevy_reflect: Add GetTypeRegistration impl for reflected tuples May 2, 2022

bors bot closed this May 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - bevy_reflect: Add `GetTypeRegistration` impl for reflected tuples #4226

[Merged by Bors] - bevy_reflect: Add `GetTypeRegistration` impl for reflected tuples #4226

MrGVSV commented Mar 16, 2022

alice-i-cecile commented Mar 16, 2022

alice-i-cecile commented May 2, 2022

bors bot commented May 2, 2022

bors bot commented May 2, 2022

bors bot commented May 2, 2022

alice-i-cecile commented May 2, 2022

bors bot commented May 2, 2022

bors bot commented May 2, 2022

[Merged by Bors] - bevy_reflect: Add GetTypeRegistration impl for reflected tuples #4226

[Merged by Bors] - bevy_reflect: Add GetTypeRegistration impl for reflected tuples #4226

Conversation

MrGVSV commented Mar 16, 2022

Objective

Solution

alice-i-cecile commented Mar 16, 2022

alice-i-cecile commented May 2, 2022

bors bot commented May 2, 2022

bors bot commented May 2, 2022

bors bot commented May 2, 2022

alice-i-cecile commented May 2, 2022

bors bot commented May 2, 2022

bors bot commented May 2, 2022

[Merged by Bors] - bevy_reflect: Add `GetTypeRegistration` impl for reflected tuples #4226

[Merged by Bors] - bevy_reflect: Add `GetTypeRegistration` impl for reflected tuples #4226