Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - use elapsed on instant #4599

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - use elapsed on instant #4599

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

@mockersf @agluszak
use elapsed on instant
db70c64 
Co-Authored-By: Andrzej Głuszak <1674445+agluszak@users.noreply.github.com>
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 26, 2022
alice-i-cecile
alice-i-cecile approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is trivial, but I'll merge it tomorrow.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples A-Tasks Tools for parallel and async work S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Apr 26, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2022
@mockersf
use elapsed on instant (#4599)
d5e770d 
# Objective

- reopen #4497 on main
- Make the example a tiny bit more elegant
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title use elapsed on instant [Merged by Bors] - use elapsed on instant Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@mockersf @exjam
use elapsed on instant (bevyengine#4599)
3d1daf2 
# Objective

- reopen bevyengine#4497 on main
- Make the example a tiny bit more elegant
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
use elapsed on instant (bevyengine#4599)
a58195d 
# Objective

- reopen bevyengine#4497 on main
- Make the example a tiny bit more elegant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Tasks Tools for parallel and async work C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @alice-i-cecile