Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - rename send_default_event to send_event_default on world #5383

Closed
wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

after #5355, three methods were added on world:

  • send_event
  • send_event_batch
  • send_default_event

rename send_default_event to send_event_default for better discoverability

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jul 19, 2022
@alice-i-cecile
Copy link
Member

@aevyrie if you're on board I'll merge this right away.

@alice-i-cecile
Copy link
Member

bors r+

@aevyrie
Copy link
Member

aevyrie commented Jul 19, 2022

Do we need to update the changelog now with the new method name?

@alice-i-cecile
Copy link
Member

Should be fine; the final change log is prepared manually by Cart for the blog post.

bors bot pushed a commit that referenced this pull request Jul 19, 2022
after #5355, three methods were added on world:
* `send_event`
* `send_event_batch`
* `send_default_event`

rename `send_default_event` to `send_event_default` for better discoverability
@bors bors bot changed the title rename send_default_event to send_event_default on world [Merged by Bors] - rename send_default_event to send_event_default on world Jul 19, 2022
@bors bors bot closed this Jul 19, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
…5383)

after bevyengine#5355, three methods were added on world:
* `send_event`
* `send_event_batch`
* `send_default_event`

rename `send_default_event` to `send_event_default` for better discoverability
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…5383)

after bevyengine#5355, three methods were added on world:
* `send_event`
* `send_event_batch`
* `send_default_event`

rename `send_default_event` to `send_event_default` for better discoverability
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…5383)

after bevyengine#5355, three methods were added on world:
* `send_event`
* `send_event_batch`
* `send_default_event`

rename `send_default_event` to `send_event_default` for better discoverability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants