-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - rename send_default_event to send_event_default on world #5383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
labels
Jul 19, 2022
@aevyrie if you're on board I'll merge this right away. |
bors r+ |
aevyrie
approved these changes
Jul 19, 2022
Do we need to update the changelog now with the new method name? |
Should be fine; the final change log is prepared manually by Cart for the blog post. |
bors bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
after #5355, three methods were added on world: * `send_event` * `send_event_batch` * `send_default_event` rename `send_default_event` to `send_event_default` for better discoverability
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
rename send_default_event to send_event_default on world
[Merged by Bors] - rename send_default_event to send_event_default on world
Jul 19, 2022
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…5383) after bevyengine#5355, three methods were added on world: * `send_event` * `send_event_batch` * `send_default_event` rename `send_default_event` to `send_event_default` for better discoverability
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…5383) after bevyengine#5355, three methods were added on world: * `send_event` * `send_event_batch` * `send_default_event` rename `send_default_event` to `send_event_default` for better discoverability
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…5383) after bevyengine#5355, three methods were added on world: * `send_event` * `send_event_batch` * `send_default_event` rename `send_default_event` to `send_event_default` for better discoverability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #5355, three methods were added on world:
send_event
send_event_batch
send_default_event
rename
send_default_event
tosend_event_default
for better discoverability