Remove Query::to_readonly

crates/bevy_ecs/src/system/mod.rs

@@ -956,130 +956,6 @@ mod tests {
             );
         }
     }
-
-    #[test]
-    fn convert_mut_to_immut() {
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<&mut A>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<&A>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<Option<&mut A>>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<Option<&A>>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<(&mut A, &B)>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<(&A, &B)>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<(&mut A, &mut B)>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<(&A, &B)>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<(&mut A, &mut B), With<C>>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<(&A, &B), With<C>>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<(&mut A, &mut B), Without<C>>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<(&A, &B), Without<C>>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<(&mut A, &mut B), Added<C>>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<(&A, &B), Added<C>>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-
-        {
-            let mut world = World::new();
-
-            fn mutable_query(mut query: Query<(&mut A, &mut B), Changed<C>>) {
-                for _ in &mut query {}
-
-                immutable_query(query.to_readonly());
-            }
-
-            fn immutable_query(_: Query<(&A, &B), Changed<C>>) {}
-
-            let mut sys = IntoSystem::into_system(mutable_query);
-            sys.initialize(&mut world);
-        }
-    }
-
     #[test]
     fn update_archetype_component_access_works() {
         use std::collections::HashSet;

crates/bevy_ecs/src/system/query.rs

@@ -302,24 +302,6 @@ impl<'w, 's, Q: WorldQuery, F: WorldQuery> Query<'w, 's, Q, F> {
         }
     }
 
-    /// Returns another `Query` from this that fetches the read-only version of the query items.
-    ///
-    /// For example, `Query<(&mut A, &B, &mut C), With<D>>` will become `Query<(&A, &B, &C), With<D>>`.
-    /// This can be useful when working around the borrow checker,
-    /// or reusing functionality between systems via functions that accept query types.
-    pub fn to_readonly(&self) -> Query<'_, 's, Q::ReadOnly, F::ReadOnly> {
-        let new_state = self.state.as_readonly();
-        // SAFETY: This is memory safe because it turns the query immutable.
-        unsafe {
-            Query::new(
-                self.world,
-                new_state,
-                self.last_change_tick,
-                self.change_tick,
-            )
-        }
-    }
-
     /// Returns an [`Iterator`] over the read-only query items.
     ///
     /// # Example