-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal Antialiasing (TAA) #7291
Conversation
This reverts commit 49af70d.
HandleUntyped::weak_from_u64(Shader::TYPE_UUID, 656865235226276); | ||
|
||
/// Plugin for temporal antialiasing. Disables multisample antialiasing (MSAA). | ||
pub struct TemporalAntialiasPlugin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with others here, it should be TemporalAntiAlias
.
const HISTORY_BLEND_RATE: f32 = 0.1; | ||
const MIN_HISTORY_BLEND_RATE: f32 = 0.015; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From where do these come? And what do they mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it up, and decided on these values through trial and error. I'll add some docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see mention of 90% / 10% somewhere, but the MIN_HISTORY_BLEND_RATE value I don't know.
Co-authored-by: Robert Swain <robert.swain@gmail.com>
Co-authored-by: Robert Swain <robert.swain@gmail.com>
Co-authored-by: Robert Swain <robert.swain@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this meets the bar. Thanks for implementing this in the first place, and for your patience waiting for review. :)
Objective
Solution
Followup Work
Changelog