Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't panic on unknown ambiguity #7950

Merged
merged 2 commits into from
Mar 12, 2023
Merged

don't panic on unknown ambiguity #7950

merged 2 commits into from
Mar 12, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 7, 2023

Objective

Solution

  • Panic in bevy_ecs, probably related to windowing #7949 happens because the exit_on_all_closed system is used to declare an ambiguity with another, but it isn't added if the exit condition is not OnPrimaryClosed
  • while we could fix all cases in Bevy, having ambiguities with unknown systems can be something that happens with optional / third party plugins
  • allow ambiguity with things that don't exist

@mockersf mockersf added A-ECS Entities, components, systems, and events P-Crash A sudden unexpected crash labels Mar 7, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10.1 milestone Mar 7, 2023
alice-i-cecile
alice-i-cecile approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm happy to make that a little less twitchy.

@alice-i-cecile alice-i-cecile mentioned this pull request Mar 11, 2023
Closed
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 12, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 12, 2023
Merged via the queue into bevyengine:main with commit d8b7fed Mar 12, 2023
@mockersf mockersf mentioned this pull request Mar 12, 2023
Closed
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@mockersf @Shfty
don't panic on unknown ambiguity (bevyengine#7950)
dc97fd4
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@mockersf @Shfty
don't panic on unknown ambiguity (bevyengine#7950)
0a5dd21
mockersf added a commit that referenced this pull request Mar 27, 2023
@mockersf
don't panic on unknown ambiguity (#7950)
80ed133
@zwazel zwazel mentioned this pull request Apr 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@nicoburns nicoburns nicoburns left review comments

@james7132 james7132 james7132 approved these changes

@maniwani maniwani Awaiting requested review from maniwani

@JoJoJet JoJoJet Awaiting requested review from JoJoJet

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

Panic in bevy_ecs, probably related to windowing
4 participants
@mockersf @nicoburns @james7132 @alice-i-cecile