Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: register Cascade in the TypeRegistry #8088

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: register Cascade in the TypeRegistry #8088

merged 1 commit into from
Mar 15, 2023

Conversation

BlondeBurrito
Copy link
Contributor

Objective

Fixes #8087

Attempting to serialize an entity containing a DirectionalLightBundle fails as the Cascade component isn't in the type registry.

Solution

  • Register Cascade

Changelog

  • Register Cascade in the TypeRegistry resource

@superdump
Copy link
Contributor

I don’t think cascades themselves should be serialised, rather just the configuration of the cascades if possible. But that’s a fly by thought.

@MrGVSV MrGVSV added A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Reflection Runtime information about types C-Bug An unexpected or incorrect behavior A-Scenes Serialized ECS data stored on the disk labels Mar 14, 2023
superdump
superdump approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can figure out what should and shouldn’t be serialised later. There are probably other things that are being serialised that shouldn’t be so it’s a bigger question.

@superdump superdump added this pull request to the merge queue Mar 15, 2023
Merged via the queue into bevyengine:main with commit 602f3ba Mar 15, 2023
@MrGVSV
Copy link
Member

MrGVSV commented Mar 15, 2023

We can figure out what should and shouldn’t be serialised later. There are probably other things that are being serialised that shouldn’t be so it’s a bigger question.

Ideally we'll figure out some good defaults once #6793 gets merged.

@mockersf mockersf added this to the 0.10.1 milestone Mar 16, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@BlondeBurrito @Shfty
fix: register Cascade in the TypeRegistry (bevyengine#8088)
34ee4e8
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@BlondeBurrito @Shfty
fix: register Cascade in the TypeRegistry (bevyengine#8088)
d3aea69
mockersf pushed a commit that referenced this pull request Mar 27, 2023
@BlondeBurrito @mockersf
fix: register Cascade in the TypeRegistry (#8088)
6b93a96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-Rendering Drawing game state to the screen A-Scenes Serialized ECS data stored on the disk C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: In Progress
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.

Reflection: Cascade component
5 participants
@BlondeBurrito @superdump @MrGVSV @tim-blackbird @mockersf