Just print out name string, not the entire Name struct #8494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This is just an oversight on my part when I implemented this in #7186, there isn't much reason to print out the hash of a
Name
like it does currently:Solution
Instead it would be better if we just printed out the string like so:
As it conveys all of the information in a less cluttered and immediately intuitive way which was the original purpose of
DebugName
. Which I also think translates toName
as well since I mostly see it as a thin wrapper around a string.