Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Camera3dBundle::tonemapping to Default #8753

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Change Camera3dBundle::tonemapping to Default #8753

merged 1 commit into from
Jun 5, 2023

Conversation

ameknite
Copy link
Contributor

@ameknite ameknite commented Jun 5, 2023

Objective

Solution

  • Change the default value Camera3dBundle::tonemapping from Tonemapping::ReinhardLuminance to Default::default() (Tonemapping::TonyMcMapface)

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jun 5, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Jun 5, 2023
@alice-i-cecile alice-i-cecile requested a review from JMS55 June 5, 2023 01:44
alice-i-cecile
alice-i-cecile approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Let's make sure to get this in the same release.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 5, 2023
JMS55
JMS55 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew I had missed something 😅, thanks for catching this!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 5, 2023
Merged via the queue into bevyengine:main with commit 94dce09 Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@ameknite @alice-i-cecile @JMS55