Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC Numbering #4

Closed
aevyrie opened this issue Apr 14, 2021 · 2 comments · Fixed by #24
Closed

RFC Numbering #4

aevyrie opened this issue Apr 14, 2021 · 2 comments · Fixed by #24

Comments

@aevyrie
Copy link
Member

aevyrie commented Apr 14, 2021

As mentioned here by @DJMcNab, it may be beneficial to number RFCs, and would require little to no effort on the maintainers' side.

#2 (comment)

It's not just about uniqueness - it's useful for ordering/exploring.
Like low number RFCs are past and are expected to be somewhat outdated.
The numbering is assigned based on the GitHub pull request number, which means that
Ensuring that we increment numbers correctly / avoid collisions
is easy because GitHub handles it for us

For context, this is @cart's initial comment on RFC numbering:

bevyengine/bevy#1662 (comment)

I don't see much utility in numbering RFCs. We can already reference them via their "github issue number" and their "unique feature name" (which we require in the title). Ensuring that we increment numbers correctly / avoid collisions feels like wasted effort.

@cart
Copy link
Member

cart commented May 19, 2021

I'm coming around on the "github issue number as prefix in rfc name" idea. It doesn't add much friction and I do like the sorting it gives us.

@alice-i-cecile
Copy link
Member

This is ~approximately policy now; just need to update the README :)

@cart cart closed this as completed in #24 May 25, 2021
Weibye pushed a commit to Weibye/rfcs that referenced this issue Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants