Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Implement proposal segment api redesign #490

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Jan 12, 2021

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title types: Implement segment api refactor types: Implement proposal segment api redesign Jan 12, 2021
@Xuanwo Xuanwo linked an issue Jan 12, 2021 that may be closed by this pull request
Copy link
Member

@Prnyself Prnyself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 919724d into master Jan 12, 2021
@Xuanwo Xuanwo deleted the feature/segment branch January 12, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment API is not recovery friendly
2 participants