Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MGDSTRM-9117] Canary support provided TLS trusted certificate #768

Merged
merged 1 commit into from
Jul 11, 2022
Merged

[MGDSTRM-9117] Canary support provided TLS trusted certificate #768

merged 1 commit into from
Jul 11, 2022

Conversation

MikeEdgar
Copy link
Contributor

  • Conditionally use TLS certificate from MK CR when available, else use the Strimzi CA certificate (current behavior)
  • Remove obsolete canary option to use non-existent internal port 9093 (MGDSTRM-9118)

@MikeEdgar
[MGDSTRM-9117] Canary support provided TLS trusted certificate
9e80c1e 
- Conditionally use TLS certificate from MK CR when available, else use
the Strimzi CA certificate (current behavior)
- Remove obsolete canary option to use non-existent internal port 9093
(MGDSTRM-9118)

Signed-off-by: Michael Edgar <medgar@redhat.com>
@github-actions github-actions bot added the operator changes related to operator label Jul 8, 2022
@MikeEdgar MikeEdgar added this to the 0.25.0 milestone Jul 8, 2022
rareddy
rareddy approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vbusch
vbusch approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@vbusch vbusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikeEdgar MikeEdgar merged commit dca59e8 into bf2fc6cc711aee1a0c2a:main Jul 11, 2022
@MikeEdgar MikeEdgar deleted the canary-tls-fix branch July 11, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbusch vbusch vbusch approved these changes

@rareddy rareddy rareddy approved these changes

@k-wall k-wall Awaiting requested review from k-wall

@shawkins shawkins Awaiting requested review from shawkins

@biswassri biswassri Awaiting requested review from biswassri

Assignees
No one assigned
Labels
operator changes related to operator
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeEdgar @rareddy @vbusch