Skip to content

Commit

Permalink
Fix: the dir="ltr" attribute breaks the handling of the standard mult…
Browse files Browse the repository at this point in the history
…ilang filter in Moodle.
  • Loading branch information
srobotta committed Feb 27, 2024
1 parent dda8626 commit 3fcd02a
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 8 deletions.
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,13 @@ of the editor are converted to correct language tags that can be used within the
If the [multilang2 filter][1] is installed
and active on the Moodle site, the `{mlan xx}` annotation is used, where `xx` is the iso code of
the selected language. If the [multilang2 filter][1] is not installed, the language tags are
transformed into the standard Moodle annotation is used. These are span elements that look like
transformed into the standard Moodle annotation. These are span elements that look like
`<span class="multilang" lang="xx" dir="ltr">`, where `xx` contains the iso code of the language
and the `dir` attribute annotates whether this is a left to right language or vice versa.

Note: for the moment the `dir="ltr"` attribute is not included in the code because
it breaks the Moodle multilanguage filter.

When loading a text, both annotations are read and translated into marked language tags in the
WYSIWYG mode. If mixed annotations are used in the text, these are preserved upon
saving.
Expand All @@ -110,6 +113,10 @@ provided iso codes is preserved.

## Version History

### Master
- Removal of the attribute `dir` e.g. `dir="ltr"` for language direction because it
breaks the standard multilanguage filter in Moodle.

### 1.1
- Fix finally [There are some issues with the latest version #6](https://github.com/bfh/moodle-tiny_multilang2/issues/6)
- Fix problem with already defined behat test steps by switching behat class to use traits
Expand Down
2 changes: 1 addition & 1 deletion amd/build/ui.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 3fcd02a

Please sign in to comment.