Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mobile support to jsnes #20

Closed
wants to merge 1 commit into from
Closed

Added mobile support to jsnes #20

wants to merge 1 commit into from

Conversation

joeheyming
Copy link

Using hammer.js I added a tap/hold/release function that has been tested on an ipad.
I provided mock up html and js files that work on a dummy apache server.

@drakmail
Copy link

I'm used nipple.js in my private fork and it working awesome on iPad. It can solve problem with virtual joypad.

@bfirsh
Copy link
Owner

bfirsh commented Jan 31, 2017

Thanks @joeheyming! It'd be great to get this supported properly, rather than it just be an experiment.

I think at the very least, we should have some built in code that does browser detection, and if it is a mobile browser, attempts to add overlay controls. That can be in the main emulator -- I don't think it needs to be separate.

@drakmail is the code in your fork good enough for a pull request?

@drakmail
Copy link

drakmail commented Feb 1, 2017

@bfirsh unfortunately the fork is full of dirty hacks 😅 Also I'm not sure that I could remember where was the fork hosted =/

@joeheyming
Copy link
Author

Hey! My hacks are clean :-)!

But seriously, I wrote this so long ago, I probably would just rewrite it if I had time.

@bfirsh
Copy link
Owner

bfirsh commented Sep 11, 2017

The web stuff for the emulator is now in a separate repository, so I've moved this to here. :) bfirsh/jsnes-web#20

@bfirsh bfirsh closed this Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants