Add types for exported module #413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthgoldstein
force-pushed
the
add-types
branch
2 times, most recently
from
881d60a
to
e4e7036
Compare
darthgoldstein
force-pushed
the
add-types
branch
from
e4e7036
to
964e5ce
Compare
|
@bfirsh I'd really love it if you could take a quick look and give me feedback or merge this change :) |
|
Boom, amazing thank you! I wonder if there is a way to add a simple test to this to ensure they stay in sync? No big deal if it's difficult. |
|
That the types stay in sync with the actual classes that they represent? |
|
Yeah, exactly. I wonder if there's a simple typescript lint or compile command that could run in CI, or something. Not a big deal if it's not simple. |
|
Looks like the build is broken anyway, sigh. (It's also broken on master.) |
Well that's no fun. I just uploaded #415 which should ideally fix the build issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few .d.ts files to describe the types of the exported modules for this project.
Resolve Issue 412