Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment2 #8

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Assignment2 #8

wants to merge 2 commits into from

Conversation

jairwin06
Copy link

No description provided.


Here are some photos of my process:
![shooting1] (/Users/jairwin06/Desktop/BuildingForLearning/instructional/shooting1.JPG)
![shooting2] (/Users/jairwin06/Desktop/BuildingForLearning/instructional/shooting2.JPG)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using relative links instead:

![shooting1](shooting1.JPG)

so that they show up on GitHub properly.

@afeld
Copy link
Member

afeld commented Sep 19, 2014

Hmm, a bunch of the images seem to be broken on the live version:

http://jairwin06.github.io/instructional/

I believe the problem is that the filenames are case-sensitive (.jpg filenames, but .JPG in the HTML). Mind fixing?

@afeld
Copy link
Member

afeld commented Sep 19, 2014

Also, the images and text are very clear... what do you think about doing a two-column layout, so that it's easier to see both at once?

@jairwin06
Copy link
Author

The second image isn't appearing here, although it's showing up in the react version. I must be overlooking something, but the file name is correct (case sensitive) and the source image location is the same as the others. Also, image size/appearance is varying greatly even with the same browser settings (images with the same size specifications in different html files are loading at completely different sizes on screen). Why would this be?



<div class="img">
<a target="_blank" href="casting2.htm"><img src="casting2.jpg" alt="Materials" width="400" height="266"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using casting2.JPG.

@afeld
Copy link
Member

afeld commented Oct 9, 2014

image size/appearance is varying greatly even with the same browser settings (images with the same size specifications in different html files are loading at completely different sizes on screen). Why would this be?

Sorry, I can't remember if we cleared this up during office hours... still an issue? <img> tags show the full-size image, unless constrained by width or height as element attributes or CSS properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants