rfc search: Use grep -R option rather than shell globbing #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I enjoy using this project and have recommended it to many others. When installing it on a computer with a low bash
ARG_MAX
, I noticed that the search functionality was breaking with "Argument list too long". To reproduce this, install rfc on a machine with a low ARG_MAX (my test machine was 262144), then:This PR changes
rfc
to usegrep -R
across the entire RFC cache directory rather than doing a stockgrep
against every element of the RFC directory using shell globbing. This should be more robust across embedded devices and other machines with a small amount of available memory. In my manual tests, all the output of the tool has been the same before & after this change. All tests pass as well: