-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to new staked token #4
Conversation
Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>
Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>
address public constant WSTETH = Addresses.WSTETH; | ||
address public constant STK_ABPT_V1 = Addresses.STK_ABPT_V1; | ||
Vault public constant VAULT = Vault(Addresses.BALANCER_VAULT); | ||
uint256 public constant EMISSION_PER_SECOND = 4456018518518518; // same as current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, this is fine because the emission per second is X amount of rewards given to the total staked, no matter how much is at the moment, or its units.
Right? Double-checking because in absolute numbers, the total supply units of bptv2 will for sure be different than v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it's fine, logic is based on totalSupply() whatever this is (doesn't matter the dimensions, although i'd assume for non 18 decimals there might be some rounding related issues we should investigate before deploying a non 18 decimal asset)
@@ -1,82 +1,68 @@ | |||
// SPDX-License-Identifier: MIT | |||
pragma solidity ^0.8.17; | |||
|
|||
import {AaveMisc} from 'aave-address-book/AaveMisc.sol'; | |||
import {MiscEthereum} from 'aave-address-book/MiscEthereum.sol'; | |||
import {ProxyAdmin} from 'solidity-utils/contracts/transparent-proxy/ProxyAdmin.sol'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not interface here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we don't have the interface here: https://github.com/bgd-labs/solidity-utils/tree/main/src/contracts/transparent-proxy
Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>
No description provided.