Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Generator doesn't respect method specified for link["rel"] #8

Closed
dominic opened this issue May 17, 2014 · 3 comments
Closed

Generator doesn't respect method specified for link["rel"] #8

dominic opened this issue May 17, 2014 · 3 comments

Comments

@dominic
Copy link

dominic commented May 17, 2014

Given the following snippet from the schema, the generator would be expected to call c.Put:

      "links": [
        {
          "method": "PUT",
          "rel": "create",
          ...
        }
      ]

However, link["rel"] = create is hardcoded to c.Post:

https://github.com/bgentry/heroku-go/blob/master/gen/gen.rb#L73-L78

@bgentry
Copy link
Owner

bgentry commented May 17, 2014

Cool, that should be pretty easy to resolve. Good catch.

On Friday, May 16, 2014, Dominic Dagradi notifications@github.com wrote:

Given the following snippet from the schema:

  "links": [
    {
      "method": "PUT",
      "rel": "create",
      ...
    }
  ]

However, link["rel"] = create is hardcoded to POST:

https://github.com/bgentry/heroku-go/blob/master/gen/gen.rb#L73-L78


Reply to this email directly or view it on GitHubhttps://github.com//issues/8
.

@bgentry
Copy link
Owner

bgentry commented May 19, 2014

Resolved by c5b4b95 and v0.10.2. Thanks!

@bgentry bgentry closed this as completed May 19, 2014
@dominic
Copy link
Author

dominic commented May 19, 2014

Awesome - thanks @bgentry!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants