Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -verify option #2

Closed
job opened this issue May 7, 2021 · 3 comments
Closed

Remove -verify option #2

job opened this issue May 7, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@job
Copy link
Member

job commented May 7, 2021

Simplify the code by shifting responsibility of VRP transport to elsewhere
@randomthingsandstuff
Copy link
Contributor

So, if I understand this right, -verify simply checks a signature in the JSON stuff?

@job
Copy link
Member Author

job commented May 8, 2021

Yes. The JSON data is canonicalized in a specific way and then signed, but I think it should be left as a decision for the operator where to pull the VRP set from and how to safely transport it.

@randomthingsandstuff
Copy link
Contributor

ok so more like only octorpki signs and we don't care. this is low priority till its time to refactor things.

@dutchshark dutchshark added the enhancement New feature or request label May 16, 2021
job added a commit that referenced this issue Jul 14, 2021
@job
Remove -verify option
1c1e09d 
This solves #2
@job job closed this as completed Jul 14, 2021
job added a commit that referenced this issue Oct 20, 2021
@job
Remove -verify option
9f9de8a 
This solves #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@job @randomthingsandstuff @dutchshark