Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Indexer an abstract base class #42

Closed
bgranzow opened this issue Apr 24, 2017 · 3 comments
Closed

Make Indexer an abstract base class #42

bgranzow opened this issue Apr 24, 2017 · 3 comments
Assignees
@bgranzow

Comments

@bgranzow
Copy link
Owner

Issue [#24] is making it clear that it would be convenient to have classes like:
StridedIndexer, BlockIndexer, and MixedIndexer all inherit from an abstract Indexer base class. This will probably be painful. Hopefully it's worth it.
@bgranzow bgranzow self-assigned this Apr 24, 2017
bgranzow added a commit that referenced this issue Apr 25, 2017
@bgranzow
elast: get to compile again, finish up [#42]
7e146cc
@bgranzow
Copy link
Owner Author

@shamsallah, @JustinClough

This will break backwards compatibility for some APIs.
In particular, check out this commit: 7e146cc
for the changes that will need to be made for your physics class and traction evaluator.

@ibaned
Copy link

ibaned commented Apr 25, 2017

goal has users ! huzzah !

@bgranzow
Copy link
Owner Author

the snake oil is working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgranzow bgranzow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibaned @bgranzow