Add esm support #245
Merged
Add esm support #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrins
force-pushed
the
esm-in-main-package
branch
from
7d81611
to
707c1cf
Compare
|
https://github.com/bgrins/test-tinycolor-upgrade is looking good with a test deploy from this branch. Both CJS and ESM are working as expected |
…ecome typescript in the future
This was referenced Dec 21, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a simpler solution compared with #241 by using rollup directly, and moving all the cjs implementation (including tests which get duplicated) into a subdirectory
This also replaces a number of the current tools (grunt, docco, qunit) and will need some additional work to get testing running in CI.
Todo:
Follow ups