new: search api #463
Closed
new: search api #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrnwd
reviewed
Apr 25, 2024
test/e2e.test.ts
Outdated
There was a problem hiding this comment.
I'd prefer not to actually hit the API during tests. I know that's the goal of an e2e test but how would you feel about mocking out the calls?
There was a problem hiding this comment.
hey @bgrnwd seem @ItamarShDev has not seen this message. I just happpen to be free and this seem like a nice feature for the package to have. Would you merge it if i mock out the calls?
There was a problem hiding this comment.
Indeed I missed it!
There was a problem hiding this comment.
Will remove the tests tonight
There was a problem hiding this comment.
Alright then would love to add the functionality to my current app
Thank you
ItamarShDev
force-pushed
the
add-search-api
branch
from
9670918
to
b1cae33
Compare
|
mistakenly closed it, here is the new one #494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
search api to use Fotmob search power
Checklist
Additional Comments
Anything else you'd like to add.