Support noarch recipes.

[jdblischak]

cc: @isuruf @bgruening

xref: regro/cf-scripts#394 (comment)

[isuruf]

license file path is the same now for unix and windows

[jdblischak]

license file path is the same now for unix and windows

@isuruf When did that change happen? Was it implemented in conda-forge/r-base-feedstock#61?

And just to confirm, by the same file path, you mean that Windows now also uses /lib/R/share/licenses/?

[isuruf]

Yes and yes

[jdblischak]

@isuruf Updated to always use the same file path

[bgruening]

Muha, you guys are amazing!

[jdblischak]

@isuruf @bgruening I just realized, isn't changing the installation path for R 3.5.1 but not R 3.4.1 going to cause some issues for Windows builds? For older recipes with GPL licenses, the license file will be properly packaged for R 3.4.1 but not for R 3.5.1. For new recipes with GPL licenses, the license file will be packaged properly for R 3.5.1 but not for R 3.4.1.

Do I understand the situation correctly? Is there a way we can fix this? One option would be to build a new version of R 3.4.1 on a branch that uses the new path, but that's likely to be difficult given all the recent changes in conda-forge. Is there anyway we can use a selector in the recipe to distinguish between the builds for R 3.4.1 and 3.5.1?

[bgruening]

@jdblischak we skipped 3.4.1 for now to avoid the problem with rebuilding. As 3.4.1. would also not be rebuild against GCC 7.

[isuruf]

FYI. you can do # [win and r_base=='3.4.1'] to distinguish between 3.4.1 and 3.5.1

[jdblischak]

we skipped 3.4.1 for now to avoid the problem with rebuilding. As 3.4.1. would also not be rebuild against GCC 7.

@bgruening Thanks for the explanation. I had missed PR conda-forge/conda-forge-pinning-feedstock#148

However, this still means that existing recipes with GPL licenses need to be updated for the license to be packaged for Windows. Is this something we should explore doing with the autotick bot? Or with separate PRs?

[jdblischak]

FYI. you can do # [win and r_base=='3.4.1'] to distinguish between 3.4.1 and 3.5.1

@isuruf Good to know. Thanks!

[isuruf]

However, this still means that existing recipes with GPL licenses need to be updated for the license to be packaged for Windows. Is this something we should explore doing with the autotick bot? Or with separate PRs?

PRs to the bot (to do this automatically) are welcome.