Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's see how this goes. #61

Merged
merged 30 commits into from
Nov 12, 2018
Merged

Conversation

mingwandroid
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [162]

For recipe:

  • Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

@mingwandroid
Copy link
Contributor Author

mingwandroid commented Oct 28, 2018

Can anyone at @conda-forge/r help figure this out?

  File "/Users/travis/miniconda3/lib/python3.7/site-packages/conda/models/match_spec.py", line 43, in __call__
    return super(MatchSpecType, cls).__call__(**parsed)
  File "/Users/travis/miniconda3/lib/python3.7/site-packages/conda/models/match_spec.py", line 180, in __init__
    self._match_components = self._build_components(**kwargs)
  File "/Users/travis/miniconda3/lib/python3.7/site-packages/conda/models/match_spec.py", line 367, in _build_components
    return frozendict(_make(key, value) for key, value in iteritems(kwargs))
  File "/Users/travis/miniconda3/lib/python3.7/site-packages/conda/models/match_spec.py", line 367, in <genexpr>
    return frozendict(_make(key, value) for key, value in iteritems(kwargs))
  File "/Users/travis/miniconda3/lib/python3.7/site-packages/conda/models/match_spec.py", line 361, in _make
    matcher = _implementors[field_name](value)
  File "/Users/travis/miniconda3/lib/python3.7/site-packages/conda/models/version.py", line 439, in __new__
    raise InvalidVersionSpecError(spec)
conda.exceptions.InvalidVersionSpecError: Invalid version spec: $

I cannot reproduce it locally using the following command line (and also saw no weird specs with conda-render):

conda-build -m ./.ci_support/osx_.yaml -c conda-forge recipe

recipe/meta.yaml Outdated
# Once run_exports are in place these will not be necessary:
- {{ pin_compatible('pango') }} # [not win]
- {{ pin_compatible('bzip2') }} # [not win]
- {{ pin_compatible('icu') }} $ [not win]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingwandroid this is the typo. Also there is a meta.yaml.orig included in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh! How did I not spot that (and why is it not happening locally .. questions for myself)? OK. thanks.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@mingwandroid
Copy link
Contributor Author

@isuruf, msys2 packages use an epoch package / mechanism to manage pinning. It's different than our usual way but works just fine! I'd rather not pin beyond that personally since then you have two mechanisms in play.

@isuruf
Copy link
Member

isuruf commented Nov 10, 2018

msys2 packages use an epoch package / mechanism to manage pinning.

I have some questions about this,

  1. Shouldn't this package depend on msys2-conda-epoch then?
  2. I looked at the requirements of some msys2 packages and they depend on msys2-conda-epoch >=20160418 and not on something like msys2-conda-epoch 20160418. If msys2-conda-epoch is updated, how is it guaranteed that this package will not use a package from a new epoch?

@mingwandroid
Copy link
Contributor Author

Given the two points yes. Depend on the exact epoch version here, good point. I may rebuild them later for exact pinning too.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mingwandroid
Copy link
Contributor Author

Thanks for taking this further.

@mariusvniekerk
Copy link
Member

Restarted travis which seemed to die for no good reason.

@scopatz
Copy link
Member

scopatz commented Nov 12, 2018

Thanks @mingwandroid!

@mingwandroid
Copy link
Contributor Author

Thanks all!

@mariusvniekerk mariusvniekerk merged commit 95d4514 into conda-forge:master Nov 12, 2018
@CJ-Wright
Copy link
Member

Woooooo awesome! Thank you everyone for your hard work and perseverance!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants