Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configurable postgres UID/GID #71

Merged
merged 3 commits into from
Aug 5, 2015
Merged

add configurable postgres UID/GID #71

merged 3 commits into from
Aug 5, 2015

Conversation

bgruening
Copy link
Owner

This patch was provided by @chambm to fix the UID and GID of postgres. As far as I understood this will help in running this container with a Windows directory mounted into a VM that runs this container.

@chambm please provide more information as necessary.

I would appreciate any review and thoughts about this, especially if there are any concerns about backward compatibility.

@dpryan79, @kellrott, @jmchilton

@chambm
Copy link
Contributor

chambm commented Aug 4, 2015

It probably also affects OS X: #68 - most of the issues I saw when googling this were involving boot2docker and OS X, not Windows.

@bgruening
Copy link
Owner Author

And I don't have any of these to test ;)

@dpryan79
Copy link
Contributor

dpryan79 commented Aug 5, 2015

The only obvious issue is that the current postgres id/gid are 102/106, so anyone doing a docker pull could run into problems.

@bgruening
Copy link
Owner Author

@dpryan79 I hope #73 will address this, what do you think?

@dpryan79
Copy link
Contributor

dpryan79 commented Aug 5, 2015

Yeah, it looks like #73 will take care of this.

Backward compatibility for already exported postgres exports
@bgruening
Copy link
Owner Author

@jmchilton I forgot that we wanted to migrate the startup script to the ansible playrole: galaxyproject/ansible-galaxy-extras#12
Do we want to do this now or in the next release?

@jmchilton
Copy link
Collaborator

@bgruening No need to prevent or slow your release based on that - I would like to do that some point but I don't have time this cycle. I'll make a note to update the ansible role to reflect this change though.

@bgruening
Copy link
Owner Author

@jmchilton ok, maybe I will find some time.
Are you ok with this PR?

@jmchilton
Copy link
Collaborator

@bgruening Absolutely - this looks great!

bgruening added a commit that referenced this pull request Aug 5, 2015
add configurable postgres UID/GID
@bgruening bgruening merged commit 8ec683e into dev Aug 5, 2015
@bgruening
Copy link
Owner Author

@matted thanks for your contribution. In one hour there will be a new bgruening/galaxy-stable:dev image. Please test it if you have some time.
@dpryan79 if you also could test it before the next release this would be awesome!

@dpryan79
Copy link
Contributor

dpryan79 commented Aug 5, 2015

@bgruening: Sure, when's the next release? I won't have time to test this today, but if I haven't gotten back to you by the time you come by on the 10th then remind me then.

@bgruening
Copy link
Owner Author

No clue when the next release will be. But 5 days we have at least.

@bgruening bgruening deleted the postgres-uid branch August 22, 2015 14:13
bebatut pushed a commit to bebatut/docker-galaxy-stable that referenced this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants