Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Laravel 5.4 compatibility #43

Merged
merged 6 commits into from
May 25, 2017
Merged

Conversation

rene-vorndran
Copy link
Contributor

-compatiblity to Laravel 5.4
-fixed same rule translation

@bgultekin
Copy link
Owner

As I understand from composer.json, you dismissed backward compability. That's why I should reject. If you considered backward compability and sent pull request again, I would happily accept.

Also, you can't change name and email information in composer.json for this repo. Of course you can do whatever you want, in your fork.

@bgultekin bgultekin closed this May 12, 2017
@rene-vorndran
Copy link
Contributor Author

The FormBuilder constructor changed and does now require a view parameter, thats why i changed the composer requirement. If you put my changes into a new branch (in my fork i used 1.2) composer will only load this version if "laravelcollective/html" in Version 5.4 o higher is used, so it will not break the installation for all the users that use earlier versions.

If i remove the name from composer.json will you then accept?

@bgultekin
Copy link
Owner

After short test, sure I will. BTW, Sorry for late reply, I couldn't find time to maintain repo. That's why I added two collaborators to repo, I think they are in same situation, too. If you think to use this package in a continuous project and you want, you can become a collaborator.

@bgultekin bgultekin reopened this May 18, 2017
@r-springmann
Copy link

Because the class this is based on has changed its constructor to this Syntax https://github.com/LaravelCollective/html/blob/5.4/src/FormBuilder.php

@rene-vorndran
Copy link
Contributor Author

I removed the name in composer.json. What would i have to do if a would become a colaborator? Check pull requests and maintain the project?

@bgultekin
Copy link
Owner

Yes, that's all. Of course, if you want you can write some unit tests to make it easier.

@bgultekin bgultekin merged commit 2a9bc01 into bgultekin:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants