Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdai: network does not support ENS #152

Closed
PeterTheOne opened this issue Jul 19, 2021 · 5 comments · Fixed by #162
Closed

xdai: network does not support ENS #152

PeterTheOne opened this issue Jul 19, 2021 · 5 comments · Fixed by #162
Labels
bug Something isn't working

Comments

@PeterTheOne
Copy link

Gnosis Safe CSV Airdrop app doesn't work on xdai 😢

network does not support ENS (operation="ENS", network="xdai", code=UNSUPPORTED_OPERATION, version=providers/5.4.0)

Even without ENS I would expect that I can send to addresses without ENS.
@schmanu schmanu added the bug Something isn't working label Jul 19, 2021
@schmanu
Copy link
Collaborator

schmanu commented Jul 19, 2021

Thanks for reporting this issue.

I won't be able to work on it this week, but will fix this bug the week after and publish a new version.

@bh2smith
Copy link
Owner

I won't be able to work on it this week, but will fix this bug the week after and publish a new version.

We should probably also double check that it's still works with rinkeby at the same time as I suspect this is probably a current issue there as well.

@schmanu
Copy link
Collaborator

schmanu commented Jul 26, 2021

We should probably also double check that it's still works with rinkeby at the same time as I suspect this is probably a current issue there as well.

On Rinkeby everything works fine for me.
But fixing this on xdai will also fix it on any other network where ens is not supported.

schmanu added a commit that referenced this issue Jul 26, 2021
@schmanu
checks if selected network supports ens
d55eb9f 
- if ens is not supported by current network, no lookup / resolution will take place.
- in xDai network we display xDai instead of ETH for native transfers

fixes #152
@schmanu schmanu mentioned this issue Jul 26, 2021
Merged
schmanu added a commit that referenced this issue Jul 26, 2021
@schmanu
checks if selected network supports ens (#162)
64b97b5 
- if ens is not supported by current network, no lookup / resolution will take place
- in xDai network we display xDai instead of ETH for native transfers
- if an ens name is given instead of a token address we do not reverse lookup the resolved address anymore

fixes #152
@schmanu schmanu reopened this Jul 26, 2021
@schmanu
Copy link
Collaborator

schmanu commented Jul 26, 2021

The issue is fixed in the next release. I'll ping here when the next version is published and available in the gnosis safe apps.

@schmanu schmanu mentioned this issue Aug 3, 2021
Closed
@schmanu
Copy link
Collaborator

schmanu commented Aug 3, 2021

@PeterTheOne
The app has been updated in the gnosis safe apps.
You should be able to use it now on xDai network.

Thanks for submitting this bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

checks if selected network supports ens bh2smith/safe-airdrop
3 participants
@PeterTheOne @schmanu @bh2smith