Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rubocop, removed Ruby 1.8.x support. #6

Merged
merged 3 commits into from
Sep 30, 2014

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Sep 26, 2014

Added Rubocop.
Time to retire Ruby 1.8.7 which is no longer supported.
Fixes #5.
Acknowledge that this is extracted from Hyperclient, the gist mentioned was a copy-paste from it.

@coveralls
Copy link

Coverage Status

Coverage increased (+37.99%) when pulling f59ca31 on dblock:added-rubocop into c53f9fa on bhaberer:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+37.99%) when pulling 6de685a on dblock:added-rubocop into c53f9fa on bhaberer:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+37.99%) when pulling 5b10ffe on dblock:added-rubocop into c53f9fa on bhaberer:master.

bhaberer added a commit that referenced this pull request Sep 30, 2014
Added Rubocop, removed Ruby 1.8.x support.
@bhaberer bhaberer merged commit c6e9b48 into bhaberer:master Sep 30, 2014
@dblock dblock deleted the added-rubocop branch May 10, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out testing!
3 participants