Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider :ghostwheel key in :compiler-options valid #706

Closed
gnl opened this issue Jun 28, 2018 · 6 comments
Closed

Consider :ghostwheel key in :compiler-options valid #706

gnl opened this issue Jun 28, 2018 · 6 comments

Comments

@gnl
Copy link

gnl commented Jun 28, 2018

I recently released Ghostwheel – it works great with Figwheel, except that the latter displays an ominous error at startup when it finds the :ghostwheel key in the :compiler-options – Ghostwheel uses them in a similar way to Devcards. Can I get an exception for that and have the key be considered valid?

@bhauman
Copy link
Owner

bhauman commented Jun 28, 2018

You got it.

@bhauman bhauman closed this as completed Jun 28, 2018
@bhauman bhauman reopened this Jun 28, 2018
@bhauman
Copy link
Owner

bhauman commented Jun 28, 2018

Also it will work fine in https://github.com/bhauman/figwheel-main

@bhauman
Copy link
Owner

bhauman commented Jun 28, 2018

d82593e

@gnl
Copy link
Author

gnl commented Jun 29, 2018

Perfect, thanks!

@gnl gnl closed this as completed Jun 29, 2018
@bhauman
Copy link
Owner

bhauman commented Jun 29, 2018

Actually I did this too quickly, I created :external-config expressly for this purpose, so that arbitrary keys could be passed through the validation. cljs-devtools follow's this convention.

https://github.com/binaryage/cljs-devtools/blob/master/docs/configuration.md#configuration-via-compiler-options

I highly recommend you follow this pattern as well.

gnl added a commit to gnl/ghostwheel that referenced this issue Jun 30, 2018
@gnl
Copy link
Author

gnl commented Jun 30, 2018

Done. This is definitely cleaner than introducing exceptions for every new project that pops up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants