Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for :npm-deps false and latest :npm-deps docs #678

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

mfikes
Copy link
Contributor

@mfikes mfikes commented Apr 16, 2018

Allow :npm-deps to additionally take on the value of false. This is allowed with ClojureScipt 1.10.238 (see clojure/clojurescript@486de1a)

Also update the doc string to match the :npm-deps site documentation (https://clojurescript.org/reference/compiler-options#npm-deps)

@mfikes
Copy link
Contributor Author

mfikes commented Apr 16, 2018

By the way, this will be really nice for React Native Figwheel users: A gigantic node_modules tree gets created for use by the React Native packager, and ClojureScript doesn't need to process that tree. By being able to set this to false users will have Figwheel start up instantly (for me, without this, approximately 45 seconds are taken while the compiler needlessly indexes node_modules).

@bhauman bhauman merged commit 17d3a92 into bhauman:master Apr 17, 2018
@bhauman
Copy link
Owner

bhauman commented Apr 17, 2018

Thanks Mike!

@vkramskikh
Copy link

Thanks! Must have for reagent-0.8-based projects. Any plans to release this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants