Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PDB Insertion codes #53

Closed
Traksewt opened this issue Oct 31, 2014 · 1 comment
Closed

Support PDB Insertion codes #53

Traksewt opened this issue Oct 31, 2014 · 1 comment

Comments

@Traksewt
Copy link

Insertion codes are currently ignored which leave gaps in the PDB.
1fiz is an example of a PDB with insertion codes at ~ residue 126 (among others).

You can see the problem when PV renders it here:
http://aquaria.ws/P29293/1fiz/A?viewer=webgl

You can also see here PV integrated with Aquaria! Sure beats Java3D for startup time and general Java woes.
biasmv added a commit that referenced this issue Oct 31, 2014
@biasmv
parse insertion codes from PDB files
9ec0a62 
PDB loading has been adapted to honor insertion codes for residues.
It also uses insertion codes for HELIX/SHEET records. There are
still a few other places that do not know about insertion codes.
Prominent examples are the coloring methods or selection by residue
number. Nonetheless, this fixes the worst of #53.
@biasmv
Copy link
Owner

biasmv commented Oct 31, 2014

Added in 9ec0a62.

Aquaria looks very nice by the way!

@biasmv biasmv closed this as completed Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@biasmv @Traksewt