Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Versification as part of a burrito #212

Closed
jag3773 opened this issue Aug 20, 2020 · 11 comments
Closed

Rework Versification as part of a burrito #212

jag3773 opened this issue Aug 20, 2020 · 11 comments
Assignees
Milestone

Comments

@jag3773
Copy link
Collaborator

jag3773 commented Aug 20, 2020

Currently, versification is a standalone flavor but it should be built into at least the following flavortypes:

  • Scripture
  • Gloss
  • parascriptural
@jag3773 jag3773 added this to the SB 0.3.0-beta milestone Aug 20, 2020
@jag3773 jag3773 added Talk About This! Consider putting this issue on the agenda for an SB meeting and removed Talk About This! Consider putting this issue on the agenda for an SB meeting labels Nov 12, 2020
@jtauber
Copy link
Collaborator

jtauber commented Dec 10, 2020

Does this mean shipping a .vrs file inside each SB that references to a versification system rather than just referring to it by name?

@jtauber jtauber added Talk About This! Consider putting this issue on the agenda for an SB meeting Question Further information is requested labels Dec 10, 2020
@FoolRunning
Copy link
Collaborator

Most projects have customized their versification in some way so it makes sense that they should be included with the project.

@jag3773
Copy link
Collaborator Author

jag3773 commented Dec 11, 2020

Ideally, the current project's versification could be provided as a delta against a known "standard" versification.

I think @jonathanrobie and versification group was going to define how this happens (maybe they have already?).

For non-Scripture types, I think we just need to reference the versification scheme being used. For example, a set of translation notes shouldn't be able to customize a versification scheme, but it may be keyed to a BCV scheme and the tool just needs to know which one that is.

@FoolRunning
Copy link
Collaborator

FoolRunning commented Dec 11, 2020

For example, a set of translation notes shouldn't be able to customize a versification scheme, but it may be keyed to a BCV scheme and the tool just needs to know which one that is.

But that versification scheme would probably be a customized version belonging to a project, would it not? If we just reference it "by name", then that means we need to have a name (or some designation) for every customized versification that exists.

@jonathanrobie
Copy link
Collaborator

jonathanrobie commented Dec 14, 2020 via email

@jag3773 jag3773 removed Question Further information is requested Talk About This! Consider putting this issue on the agenda for an SB meeting labels Jan 7, 2021
@jag3773
Copy link
Collaborator Author

jag3773 commented Jan 7, 2021

@jtauber to prep and then talk to @jonathanrobie about possible work needed in versification group.

@jtauber
Copy link
Collaborator

jtauber commented Feb 4, 2021

See #243 for discussion for @jonathanrobie to take to versification group.

@jtauber
Copy link
Collaborator

jtauber commented Feb 11, 2021

As discussed last week and in #243, all deltas will be expressed against org and no other versification system. They may have originally been expressed as delta to some other versification system but, for the purposes of generating a burrito, the delta against org is calculated and that is all that can be in a burrito.

@jonathanrobie
Copy link
Collaborator

jonathanrobie commented Feb 11, 2021 via email

@jtauber
Copy link
Collaborator

jtauber commented Mar 11, 2021

I think this is now going to be done as a new role for an ingredient which is a delta from the org versification to the versification used in the burrito. In which case I think #248 will cover it and this can be closed. But is there anything else that needs to be done? Is a role on an ingredient sufficient?

@jtauber jtauber added Talk About This! Consider putting this issue on the agenda for an SB meeting Close Request Someone wants to close this - close or clear label labels Mar 11, 2021
@jag3773 jag3773 removed the Talk About This! Consider putting this issue on the agenda for an SB meeting label Mar 11, 2021
@jtauber jtauber removed the Close Request Someone wants to close this - close or clear label label Mar 18, 2021
@jtauber
Copy link
Collaborator

jtauber commented Mar 18, 2021

as now covered by #248, this can be closed.

@jtauber jtauber closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants