Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gradually to std::filesystem #952

Open
2 of 12 tasks
teusbenschop opened this issue Aug 2, 2024 · 2 comments
Open
2 of 12 tasks

Move gradually to std::filesystem #952

teusbenschop opened this issue Aug 2, 2024 · 2 comments
Assignees
@teusbenschop
Labels
enhancement pending

Comments

@teusbenschop
Copy link
Member

teusbenschop commented Aug 2, 2024 •
edited
Loading

It is now time to use the newer filesystem calls from the std::filesystem library.

To keep testing whether it keeps working after the move.

  • Cloud.
  • Linux tarball.
  • Cloud Ubuntu package.
  • Client Ubuntu package.
  • Debian packages - assumed to be good - not yet tested.
  • Android - 5 out of 6 devices had crashes in C++ - remain with the C API - to be retried later.
  • iOS - It builds with std::filesystem but the app is very slow in the simulator - to be retried later.
  • macOS
  • Windows - may requirer newer Visual Studio
  • If Windows done: Remove thestd::wstring: Nope, this is still needed for other calls.
  • If done: Remove DIRECTORY_SEPARATOR
  • If done: Remove USE_STD_FILESYSTEM
@teusbenschop teusbenschop self-assigned this Aug 10, 2024
teusbenschop added a commit that referenced this issue Aug 10, 2024
@teusbenschop
Write unit test for copying a file
bfc68e9 
#952
teusbenschop added a commit that referenced this issue Aug 10, 2024
@teusbenschop
Create a definition for whether to use std::filesystem
742a286 
#952
teusbenschop added a commit that referenced this issue Aug 11, 2024
@teusbenschop
Cloud uses std::filesystem to copy files
315124a 
#952
@teusbenschop teusbenschop mentioned this issue Aug 11, 2024
Merged
teusbenschop added a commit that referenced this issue Aug 11, 2024
@teusbenschop
Mark candidates for std::filesystem use
71189eb 
#952
teusbenschop added a commit that referenced this issue Aug 15, 2024
@teusbenschop
Cloud has moved to std::filesystem
fddaea2 
#952
teusbenschop added a commit to bibledit/android that referenced this issue Aug 17, 2024
@teusbenschop
Refresh kernel
89fce25 
This uses the std::filesystem now.
bibledit/cloud#952
@teusbenschop
Copy link
Member Author

When enabling std::filesystem on Android, several devices had native crashes. This are crashes in C++.

Device(s) with issues
Google Pixel 6 (oriole) - Android 12
Google Pixel 5 64-bit only (redfin_64) - Android 13
Google Pixel 7 (panther) - Android 13
Motorola Motorola G20 (java) - Android 11
Generic Small Desktop (x86) (SmallDesktop.x86) - Android 12L

Exceptions
Native crash of org.bibledit.android
Native crash of org.bibledit.android
Native crash of org.bibledit.android
Native crash of org.bibledit.android
Native crash of org.bibledit.android
Native crash of org.bibledit.android

teusbenschop added a commit to bibledit/android that referenced this issue Aug 18, 2024
@teusbenschop
Update to API 34
58751f1 
bibledit/cloud#952
teusbenschop added a commit to bibledit/android that referenced this issue Aug 18, 2024
@teusbenschop
Disable std::filesystem and use C call
e811483 
bibledit/cloud#952
teusbenschop added a commit to bibledit/android that referenced this issue Aug 18, 2024
@teusbenschop
Bump version
9c82413 
bibledit/cloud#952
teusbenschop added a commit to bibledit/packaging that referenced this issue Aug 18, 2024
@teusbenschop
New versions
25b6b1c 
bibledit/cloud#952
teusbenschop added a commit to bibledit/ios that referenced this issue Aug 18, 2024
@teusbenschop
Use std::filesystem
c64022d 
bibledit/cloud#952
teusbenschop added a commit that referenced this issue Aug 20, 2024
@teusbenschop
Enable build with mbed tls v2
4d242a7 
#952
teusbenschop added a commit that referenced this issue Aug 20, 2024
@teusbenschop
Version bump
b6e2305 
#952
teusbenschop added a commit that referenced this issue Aug 20, 2024
@teusbenschop
iOS still uses C calls for file system
3ae6460 
#952
teusbenschop added a commit to bibledit/windows that referenced this issue Aug 24, 2024
@teusbenschop
Updated kernel
e9d30b3 
bibledit/cloud#952

This still has std::filesystem disabled for Windows.
teusbenschop added a commit to bibledit/windows that referenced this issue Aug 24, 2024
@teusbenschop
Remove delete d file from sources
f70bd8c 
bibledit/cloud#952
teusbenschop added a commit that referenced this issue Aug 24, 2024
@teusbenschop
Switch Windows to std::filesystem
a4480f7 
#952
teusbenschop added a commit to bibledit/windows that referenced this issue Aug 24, 2024
@teusbenschop
Updated kernel
36f231b 
bibledit/cloud#952

Updated to enable std::filesystem in Windows.
teusbenschop added a commit that referenced this issue Aug 25, 2024
@teusbenschop
Rename #define
cfe967d 
#952
teusbenschop added a commit that referenced this issue Aug 25, 2024
@teusbenschop
Enable std::filesystem on macOS
c1e9369 
#952
teusbenschop added a commit that referenced this issue Aug 25, 2024
@teusbenschop
Fix define for macOS
bd7ea1e 
#952
teusbenschop added a commit to bibledit/macos that referenced this issue Aug 25, 2024
@teusbenschop
Update kernel for using std::filesystem
37234d3 
bibledit/cloud#952
@teusbenschop
Copy link
Member Author

For Ubuntu 22.04 see this issue: #960 That is why the std::filesystem is disabled for all of Cloud and Linux client, just to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teusbenschop teusbenschop

Labels
enhancement pending
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teusbenschop