Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Windows embedded web control #965

Closed
teusbenschop opened this issue Aug 24, 2024 · 2 comments
Closed

Use Windows embedded web control #965

teusbenschop opened this issue Aug 24, 2024 · 2 comments

Comments

@teusbenschop
Copy link
Member

teusbenschop commented Aug 24, 2024

Investigate whether it is possible to use the embedded web control provided by Windows on both Windows 10 and Windows 11.

This would free the app from CEF Sharp that it now uses, which is a few hundred Megabytes large. Thus the app would become much smaller than it is now in size in Megbytes. Another advantages would be that CEF Sharp does not need to be updated anymore, since it's not included.

If investigation shows that the embedded web control cannot be used yet, then update the CEF Sharp package to the newest version.

@teusbenschop
Copy link
Member Author

teusbenschop commented Oct 3, 2024

Tutorial: https://learn.microsoft.com/en-us/microsoft-edge/webview2/get-started/winforms

With the above tutorial, with source set to https::/bibledit.org:8091, downloading a file works out of the box, and printing a web page works out of the box too.

teusbenschop added a commit to teusbenschop/laboratory that referenced this issue Oct 12, 2024
teusbenschop added a commit to bibledit/windows that referenced this issue Oct 12, 2024
teusbenschop added a commit to bibledit/windows that referenced this issue Oct 13, 2024
@teusbenschop
Copy link
Member Author

Once the Microsoft.Webview2 package is installed via NuGet, and the current Inno Setup Installer does its work, the Microsoft Webview .DLL files get installed along with Bibledit in the C:\bibledit directory. Once Bibledit starts, it finds and loads those and the Webview starts. It was tested whether it indeed refers the installed .DLL files, and it does, because removing those leads to a failure to start Bibledit.

teusbenschop added a commit that referenced this issue Oct 17, 2024
teusbenschop added a commit to bibledit/windows that referenced this issue Oct 17, 2024
bibledit/cloud#965
... and move to the Microsoft.Webview2 package.
teusbenschop added a commit to bibledit/windows that referenced this issue Oct 17, 2024
teusbenschop added a commit to bibledit/windows that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant