Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few badges broken #66

Closed
vsoch opened this issue Jun 2, 2022 · 9 comments · Fixed by #73
Closed

A few badges broken #66

vsoch opened this issue Jun 2, 2022 · 9 comments · Fixed by #73

Comments

@vsoch
Copy link

vsoch commented Jun 2, 2022

Hey BIDS apps team! It looks like a column of badges are 404-ing on https://bids-apps.neuroimaging.io/apps/:

image

I suspect a circle workflow was removed, changed, or something along those lines, it looks like the Circle URL that is linked to is 404 along with the badge. https://circleci.com/gh/BIDS-Apps/aa.svg?style=shield

Just wanted to let you know!

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jun 2, 2022

thanks @vsoch

Got a hunch this is related to the renaming of the github organization in #47

@sappelhoff could this be it?

Changing the link manually to use "bids-apps" does not give a 404 but does not give something what we would expect either

https://app.circleci.com/jobs/github/bids-apps/aa/134?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@vsoch
Copy link
Author

vsoch commented Jun 2, 2022

That's indeed strange - I can see a workflow run here from about a month ago: https://app.circleci.com/pipelines/github/BIDS-Apps/bids-apps.github.io/27/workflows/d2369073-e132-4a2d-9e08-18fee8035223/jobs/27 but I get 404 clicking up levels to the root of the run. It could be a bug with CircleCI and you could try contacting support?

@sappelhoff
Copy link
Contributor

not sure, but 86bb262 might have fixed it? Docker pulls are listed as "invalid" though 🤔

image

@sappelhoff
Copy link
Contributor

This is the problematic badge now ... no idea why though:

src="https://img.shields.io/github/issues-pr-raw/{{ app.gh }}/bug.svg?maxAge=2592000"

@vsoch
Copy link
Author

vsoch commented Jun 3, 2022

The changes look great!

For the docker pulls, I think the issue might be the max age? E.g., here is an invalid tag with a max age:

https://img.shields.io/docker/pulls/nipreps/mriqc.svg?maxAge=2592000

And making it something more recent:

https://img.shields.io/docker/pulls/nipreps/mriqc.svg?maxAge=100

I played around on the page a bit - some of them are fixed when the max age is updated, and others when it is removed (the older ones). Likely it just can't get a total pulls for a time period and shows us invalid.

A few other missing ones:

and I think that's it!

@sappelhoff
Copy link
Contributor

thanks for your research!

@PeerHerholz and @akhanf did you remove the CircleCI workflow? I am not sure whether the problem is rather with us ... it might be unreasonable to require each BIDS app to have a CircleCI workflow just so that we can conveniently display this on the website 🤔

I can look into the renaming ... and regarding "trendscenter/gift-bids", I think there never was a circleci workflow.

sappelhoff added a commit that referenced this issue Jun 4, 2022
@PeerHerholz
Copy link
Collaborator

Hi folks,

thx for pointing this out and sorry for the late reply, no idea why I missed this.

IIRC I never had a CircleCI workflow implemented but a workflow on Travis (please see here). However, I can also change/adapt things.

@sappelhoff
Copy link
Contributor

no worries @PeerHerholz -- if you could migrate from travis to circleci, that'd be much appreciated as it'd give you the nice badge that we have on the website. But it's certainly not urgent or required.

Alternatively we could / should figure out whether / how we can "customize" the badges we show. E.g., add to each "app" that we list one more metadata item about their main CI flow, and then render a badge based on the status we mine from there. --> this would probably be much superior to asking all app devs to please have a circleci workflow.

@sappelhoff
Copy link
Contributor

some more discussion was in #69 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants