-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add metadata fields for DeIdentificationMethod/CodeSequence for MRI and PET #1772
Open
CGSchwarzMayo
wants to merge
14
commits into
bids-standard:master
Choose a base branch
from
CGSchwarzMayo:DeIdentificationMethod
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
62d2244
Add tags for DeIdentificationMethod and DeIdentificationMethodCodeSeq…
CGSchwarzMayo 9a32e88
Merge branch 'master' into DeIdentificationMethod
CGSchwarzMayo c5a7e5c
Correct capitalization on DeIdentificationMethod to DeidentificationM…
CGSchwarzMayo 1589e22
Merge branch 'master' into DeIdentificationMethod
CGSchwarzMayo 4fab2f4
Merge branch 'bids-standard:master' into DeIdentificationMethod
CGSchwarzMayo a53ab03
Apply suggestions from code review
CGSchwarzMayo 4327bc7
Add modality-specific-files and sidecars for DeidentificationMethod tags
CGSchwarzMayo edd7448
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 85c9e80
Update src/modality-specific-files/positron-emission-tomography.md
effigies 2c01417
Apply additional suggestions from code review
CGSchwarzMayo 450b257
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 586e839
Merge branch 'master' into DeIdentificationMethod
CGSchwarzMayo 5059935
Fix header levels
effigies 1b3f97c
Move deid section under PET metadata
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is complicated enough warranting addition to https://github.com/bids-standard/bids-examples if not as an example here in the BIDS spec text. Do we have some nice example DICOMs to check those fields out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if someone were creating these tags from scratch at the BIDS level, they would use DeidentificationMethod rather than DeidentificationMethodCodeSequence. The latter is more provided to allow direct translation by dcm->nii and dcm->bids software.
I'm attaching some nice example DICOM, as requested. This is MRI of a spaghetti squash (thanks @captainnova), and I've further de-identified it, so there's no PHI. I included the tags as if I had de-faced it, but it is a squash, so there was no face to de-face.
dcm_fruit_deidentified.zip
The relevant dcm tags look like this:
With rordenlab/dcm2niix#813, the relevant portion of json output is: