Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: Run entity are parsed as strings #237

Closed
adelavega opened this issue Aug 17, 2018 · 2 comments
Closed

layout: Run entity are parsed as strings #237

adelavega opened this issue Aug 17, 2018 · 2 comments
Labels

Comments

@adelavega
Copy link
Collaborator

It looks like the entity run is being extracted as a string, not an integer. The zero padding is correctly dealt with, but it is stored as a string.

I could have sworn we deal with this before so that it would read run in as a integer, but it looks like even in the tests, it expects strings.

@adelavega adelavega added the bug label Aug 17, 2018
@adelavega
Copy link
Collaborator Author

Looks like in bids.json, run should have dtype set to int.

Changing this breaks other grabbit stuff (other functions seems to be mostly tested on strings)

I am incorrect in recalling at some point it was reading in runs as ints though?

@tyarkoni
Copy link
Collaborator

Fixed in #236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants