Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not honoring D.4. Middlebox Compatibility Mode #200

Open
WernerWenz opened this issue Feb 10, 2019 · 2 comments
Open

Not honoring D.4. Middlebox Compatibility Mode #200

WernerWenz opened this issue Feb 10, 2019 · 2 comments

Comments

@WernerWenz
Copy link

As per RFC an arbitrary number of (empty, unencrypted) change_cipher_spec records may be send during the handshake.
Most clients will most likeley use this feature in order to increase chances for successfully establishing a TLS connection over the Internet.
OpenSSL s_client and TLS-tris for example do so and thus currently are not compatible.

Fixing might be possible at

switch RecordType(header[0]) {

However, while enabling connections from OpenSSL/tris, a simple

func (r *DefaultRecordLayer) nextRecord(allowOldEpoch bool) (*TLSPlaintext, error) {
again:
....
case RecordTypeChangeCipherSpec:
   goto again

would not be sufficient as these records must only occur unencrypted during the handshake (before the client finished).

@bifurcation
Copy link
Owner

@ekr - Is this is a spec compliance issue or a feature request?

@ekr
Copy link
Collaborator

ekr commented Feb 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants