Improved mentions UI #1128
Merged
Improved mentions UI #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AbhayVAshokan _a Please check. cc @deepakjosp |
AbhayVAshokan
requested changes
Jun 2, 2024
|
@AbhayVAshokan The options are already keyboard accessible, as I'm using NeetoUI Dropdown sub-components which are themselves keyboard friendly. Screen.Recording.2024-06-05.at.3.04.12.PM.mov |
AbhayVAshokan
approved these changes
Jun 5, 2024
deepakjosp
added a commit
that referenced
this pull request
Jun 6, 2024
* Fixed false result check of the existence of an item in the menu options. * Moved the popover component to the bottom from out of the menu list since it's a portal. * Moved the portal components out of the menubar. * Removed the collapsible menu feature and it's related code and implementations. * Fixed the layout issue after the collapse feature has been removed. * Refactored and added necessary props to the menus in the create menu options in font, history, list and block menu groups. * Moved components to components folder and created Button component. * Refactored the change in folder location of the fixed menu controls. * Refactored the Fixed menu to render the menu items from the group of menu returned from the buildMenuItems util. * Created the MoreMenu to overflowing actions. * Added logic to separate out menu groups to 2 lists based on the available space. * Fixed issues in the mention component when moved on to the secondary menu. * Fixed issues in the emoji component when moved on to the secondary menu. * Created a common target button for the seondary menu item and fixed the menu position in secondary and primary usages. * Fixed the UI issues in the text color option when moved to the secondary menu. * Fixed issues in the TableOption when the option was moved to more menu. * Fixed issues with the more menu and made it compatible with all the available options. * Fixed a few UI issues in the menu buttons and dropdowns. * Fixed the dependencies list of the buildmenu items handler. * Fixed the performance issues and the unexpected behavioural problem with in menu because of the unnecessary dependencies. * Fixed the isActive and command run issues in the menu buttons and dropdown. * Moved out the static code from the component to utils. * Fixed the typo in the filename of SecondaryMenuTarget * Created a copy of the olde buildMenuItems util for bubble menu since we made significant changes to the buildMenuItems of the fixed menu. * Removed the unused util to render the menu button. * Fixed empty tooltip of the font size option dropdown. * Fixed the empty space on the menubar. * Removed the appendTo prop and set the strategy fixed on the more dropdown component in fixed menu. * Reduces the bundle size of attachments preview. (#1125) * Updated the rollup config to support code splitting. * Added plugin to cleanup the build output each time. * Updated the upload files list in the package.json to include dist folder. * Updated the gitignore to ignore build outputs. * Lazy loaded the Preview component in the Attachment to prevent react-doc-viewer in the initial chunk of the bundle. * Removed unnecessary files from the ignore list and replaced the single quotes for strings in the rollup config with double quotes. * Replaced the singlequotes in the cleaner files list with double quotes. * Fixed the eager loading of the Preview chunk. * Updated the version name to beta. * Set a feedback to the user while fetching the Preview component chunk. * udpated version name. * Reset the version change. * v1.33.4 * Revert "Reduces the bundle size of attachments preview. (#1125)" (#1136) This reverts commit 5c87e7d. * v1.33.5 * Improved mentions UI (#1128) * Improved mentions UI * Added background color when the mentions item is active * Made necessary modifications to the special mentions --------- Co-authored-by: Abhay V Ashokan <abhayvashokan@gmail.com> * v1.33.6 * Reduces the bundle size of attachments preview. (#1137) * Updated the rollup config to support code splitting. * Added plugin to cleanup the build output each time. * Updated the upload files list in the package.json to include dist folder. * Updated the gitignore to ignore build outputs. * Lazy loaded the Preview component in the Attachment to prevent react-doc-viewer in the initial chunk of the bundle. * Removed unnecessary files from the ignore list and replaced the single quotes for strings in the rollup config with double quotes. * Replaced the singlequotes in the cleaner files list with double quotes. * Fixed the eager loading of the Preview chunk. * Updated the version name to beta. * Set a feedback to the user while fetching the Preview component chunk. * udpated version name. * Reset the version change. * Moves common dependencies to the peer list. (#1129) * Moved commons dependencies to the peer list. * Added rollup plugin visualizer. * v1.34.0 --------- Co-authored-by: Abhay V Ashokan <abhay.ashokan@bigbinary.com> Co-authored-by: Abhay V Ashokan <35297280+AbhayVAshokan@users.noreply.github.com> Co-authored-by: Praveen Murali <itspraveenmurali@gmail.com> Co-authored-by: Abhay V Ashokan <abhayvashokan@gmail.com>
deepakjosp
added a commit
that referenced
this pull request
Jun 25, 2024
* Removes slash command plugin from the customExtensions list. (#1107) * Removed slash command plugin from the customExtensions list. * Removed the slash command storybook * Updated version name to beta. * Updated neetoEditor to v1.34.0-beta1 * Updated version name. * Incremented the version to publish a release. * Audit and improves the link component. (#1109) * Added a subtle animation to the link popover component. * Replaced the custom border color and box shadow with neetoui helpers and standards that we follow. * Added a plugin to highlight the selected text when the editor is not in focus. * Added style for the selected text when the editor is out of focus. * Optimized and improvised the add link popover position and logic to calculate the position. * Optimized and fixed issues in removing the decoration applied to highlight the selection when editor was not in focus. * Added arrrow to the edit/view links popover. * Optimized the arrow and popover position to be more in sync with the cursor and selection. * Updated the link text font size and weight to make it consistent with the nearby buttons. * Updated the version to v1.35.0-beta1 * Implements responsive menu using the three dot approach. (#1118) * Fixed false result check of the existence of an item in the menu options. * Moved the popover component to the bottom from out of the menu list since it's a portal. * Moved the portal components out of the menubar. * Removed the collapsible menu feature and it's related code and implementations. * Fixed the layout issue after the collapse feature has been removed. * Refactored and added necessary props to the menus in the create menu options in font, history, list and block menu groups. * Moved components to components folder and created Button component. * Refactored the change in folder location of the fixed menu controls. * Refactored the Fixed menu to render the menu items from the group of menu returned from the buildMenuItems util. * Created the MoreMenu to overflowing actions. * Added logic to separate out menu groups to 2 lists based on the available space. * Fixed issues in the mention component when moved on to the secondary menu. * Fixed issues in the emoji component when moved on to the secondary menu. * Created a common target button for the seondary menu item and fixed the menu position in secondary and primary usages. * Fixed the UI issues in the text color option when moved to the secondary menu. * Fixed issues in the TableOption when the option was moved to more menu. * Fixed issues with the more menu and made it compatible with all the available options. * Fixed a few UI issues in the menu buttons and dropdowns. * Fixed the dependencies list of the buildmenu items handler. * Fixed the performance issues and the unexpected behavioural problem with in menu because of the unnecessary dependencies. * Fixed the isActive and command run issues in the menu buttons and dropdown. * Moved out the static code from the component to utils. * Fixed the typo in the filename of SecondaryMenuTarget * Created a copy of the olde buildMenuItems util for bubble menu since we made significant changes to the buildMenuItems of the fixed menu. * Removed the unused util to render the menu button. * Fixed empty tooltip of the font size option dropdown. * Fixed the empty space on the menubar. * Removed the appendTo prop and set the strategy fixed on the more dropdown component in fixed menu. * Reduces the bundle size of attachments preview. (#1125) * Updated the rollup config to support code splitting. * Added plugin to cleanup the build output each time. * Updated the upload files list in the package.json to include dist folder. * Updated the gitignore to ignore build outputs. * Lazy loaded the Preview component in the Attachment to prevent react-doc-viewer in the initial chunk of the bundle. * Removed unnecessary files from the ignore list and replaced the single quotes for strings in the rollup config with double quotes. * Replaced the singlequotes in the cleaner files list with double quotes. * Fixed the eager loading of the Preview chunk. * Updated the version name to beta. * Set a feedback to the user while fetching the Preview component chunk. * udpated version name. * Reset the version change. * v1.33.4 * Revert "Reduces the bundle size of attachments preview. (#1125)" (#1136) This reverts commit 5c87e7d. * v1.33.5 * Improved mentions UI (#1128) * Improved mentions UI * Added background color when the mentions item is active * Made necessary modifications to the special mentions --------- Co-authored-by: Abhay V Ashokan <abhayvashokan@gmail.com> * v1.33.6 * Reduces the bundle size of attachments preview. (#1137) * Updated the rollup config to support code splitting. * Added plugin to cleanup the build output each time. * Updated the upload files list in the package.json to include dist folder. * Updated the gitignore to ignore build outputs. * Lazy loaded the Preview component in the Attachment to prevent react-doc-viewer in the initial chunk of the bundle. * Removed unnecessary files from the ignore list and replaced the single quotes for strings in the rollup config with double quotes. * Replaced the singlequotes in the cleaner files list with double quotes. * Fixed the eager loading of the Preview chunk. * Updated the version name to beta. * Set a feedback to the user while fetching the Preview component chunk. * udpated version name. * Reset the version change. * Moves common dependencies to the peer list. (#1129) * Moved commons dependencies to the peer list. * Added rollup plugin visualizer. * v1.34.0 --------- Co-authored-by: Abhay V Ashokan <abhay.ashokan@bigbinary.com> Co-authored-by: Abhay V Ashokan <35297280+AbhayVAshokan@users.noreply.github.com> Co-authored-by: Praveen Murali <itspraveenmurali@gmail.com> Co-authored-by: Abhay V Ashokan <abhayvashokan@gmail.com> * Updated version to v1.35.1-beta1 * Updated version to v1.36.0-beta1 * Updates all tiptap packages to v2.4.0 (#1145) * Updated @tiptap/extension-bubble-menu to 2.4.0 from 2.0.0-beta.199 * Updated all tiptap packages to 2.4.0 * Fixed the focus issue when trying to edit a link. * Checked in the change minified CSS output. * Reverted the change in edit link title since the bug was fixed in the tiptap release. * Updated editor version to v1.36.2-beta1 * Replaced the resize event listener with ResizeObserver --------- Co-authored-by: Abhay V Ashokan <abhayvashokan@gmail.com> Co-authored-by: Abhay V Ashokan <abhay.ashokan@bigbinary.com> Co-authored-by: Abhay V Ashokan <35297280+AbhayVAshokan@users.noreply.github.com> Co-authored-by: Praveen Murali <itspraveenmurali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1115
After
Before
Description
Checklist
is required).
Reviewers