Replaces the usages of uppy for uploads with custom hook. #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the queue to upload and clear the queue after upload.
… awaiting each upload and sequentially uploading.
…ding to the store to be used by the AtachmentProgress component.
…he AttachmentProgress component.
…cefully handle error if an upload fails and clear only uploaded files from the store.
…when the value of changes instead of calling it on every render.
…vailble while canncelling an upload.
deepakjosp
added
the
minor
…ror if some of the files were skipped because of size or file type issues.
…more than allowed number.
|
@AbhayVAshokan _a please review. |
AbhayVAshokan
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Nice work 👌
@deepakjosp _a please merge the PR after making these changes.
deepakjosp
deleted the
1126-replace-the-usages-of-uppy-for-uploads-with-custom-hook
branch
AbhayVAshokan
restored the
1126-replace-the-usages-of-uppy-for-uploads-with-custom-hook
branch
AbhayVAshokan
deleted the
1126-replace-the-usages-of-uppy-for-uploads-with-custom-hook
branch
AbhayVAshokan
added a commit
that referenced
this pull request
Jun 24, 2024
)" This reverts commit 142c392.
deepakjosp
restored the
1126-replace-the-usages-of-uppy-for-uploads-with-custom-hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1126
Description
These changes reduced the bundle size from 4.41MB to 4.04MB when unzipped.
Checklist
I have made corresponding changes to the documentation.I have updated the types definition of modified exports.is required).
Reviewers